Add separate screen for ImageViewer#980
Merged
Merged
Conversation
Contributor
|
Is there any way with this approach to retain the transparency effect? |
Collaborator
Author
|
Not sure but I'll take a look. Didn't really think about that. |
Collaborator
Author
|
I did not find a way to do this yet. But I took a look at the other apps and none allow you to see through them. So instead I can make it always completely black |
# Conflicts: # app/src/main/java/com/jerboa/ui/components/common/Navigation.kt # app/src/main/java/com/jerboa/ui/components/community/CommunityActivity.kt
Member
|
I'd be fine with a black background also. Whatever is easier to maintain and less buggy. |
# Conflicts: # app/src/main/java/com/jerboa/MainActivity.kt # app/src/main/java/com/jerboa/ui/components/home/BottomNavActivity.kt # app/src/main/java/com/jerboa/ui/components/home/HomeActivity.kt # app/src/main/java/com/jerboa/ui/components/person/PersonProfileActivity.kt # app/src/main/java/com/jerboa/ui/components/post/PostListing.kt
Collaborator
Author
|
Improved the UX of the screen viewer jRpZ1CZ3Ew.mp4 |
dessalines
approved these changes
Jul 11, 2023
dessalines
left a comment
Member
There was a problem hiding this comment.
I tested and it works great.
|
Great stuff @MV-GH 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All though #966 could simply be fixed by doing
statusBarsPadding()for android 13. I wanted to fix the the different levels of positioning of the buttons across the supported android versions.I have attempted many things to get it work for a dialog. But i could never get it to work for all Android versions.
Examples:
Existing behaviour on older than android 13. The dialog overlaps half the status bar. Only doesn't overlap the buttons due to the padding on the buttons. Possibly will overlap on phones with bigger status bar due to a bigger notch.
Messing with fitsSystemWindows & WindowCompat.setDecorFitsSystemWindows, etc
you get this result on some android versions
After wasting several hours on this, it is in my opinion you should never bother with fullscreen dialogs. Instead I turned it into a screen/activity. And now it not only consistent with positioning across all android versions. It is placed exactly where other back buttons would be placed.
How it looks now
It retains all existing functionality.
Fixes #966