Add drawer to all main tabs and general drawer changes#991
Conversation
|
The second nav host only has pages that are on the bottom nav (home, search, inbox, saved, profile). And the bottom nav bar is outside this second nav host. This way we can avoid having the bottom nav on every page (which was how it was previously). |
I am not following, why does it require a second navhost with only bottomnav composables. Can it not use the ones defined in the root navhost? |
|
Then the bottom nav has to be duplicated on those 5 pages right? Coz what I found was the bottom nav can only be specified on the scaffold, and I couldn't come up with a better way than using a second nav host within a Scaffold. |
|
I think i understand what you mean. If i move the drawer stuff and navBottomBar to the root. It would mean all screens/composable defined in root would have the the drawer and navBottomBar? But maybe it can still be done |
# Conflicts: # app/src/main/java/com/jerboa/ui/components/common/AppBars.kt # app/src/main/java/com/jerboa/ui/components/home/BottomNavActivity.kt
|
@dessalines Fixed |
studio64_BPpxMxVGjp.mp4
Fixes #914
@nahwneeth What's the reason for the duplicate navhost in BottomNavActivity? I think it can be removed.