Add confirmation on exit#998
Conversation
|
Instead of using toasts, could we use a dialog? Other apps with a similar feature will pop up a "are you sure you want to exit?" dialog, usually with a "don't ask me again" checkbox option, and an exit and cancel button. |
|
I just copied the behaviour of what Boost did. YF7NCY92p4.mp4Boost options but honestly i don't think anyone uses the dialog thing. |
|
I might have been the one user of that dialog option, lol. |
| <string name="dialogs_top_nine_month">Top Nine Months</string> | ||
| <string name="post_listing_view_source">View Source</string> | ||
| <string name="post_listing_view_original">View Original</string> | ||
| <string name="back_warning">Repeat action to exit</string> |
There was a problem hiding this comment.
Are there are other actions besides pressing the back button/gesture equivalent that we would need to be concerned about? If not, "Press back again to exit" sounds more natural to me. Otherwise LGTM.
There was a problem hiding this comment.
Yeah I didn't want to put tap because of the back gesture, but that could work too.
There was a problem hiding this comment.
Ya I also like "Press back again to exit"
dessalines
left a comment
There was a problem hiding this comment.
To break the tie 😆 , I think the simple toast works fine, and an extra setting is probably overkill.
| <string name="dialogs_top_nine_month">Top Nine Months</string> | ||
| <string name="post_listing_view_source">View Source</string> | ||
| <string name="post_listing_view_original">View Original</string> | ||
| <string name="back_warning">Repeat action to exit</string> |
There was a problem hiding this comment.
Ya I also like "Press back again to exit"
|
I was going to add the setting, it can always be expanded to add the dialog. |
# Conflicts: # app/src/main/java/com/jerboa/MainActivity.kt
# Conflicts: # app/src/main/res/values/strings.xml
|
Added all the options bvTO7H2xxg.mp4 |
Adds a confirmation when trying to exit the app, to prevent accidental exits. I read somewhere that someone wanted this. Can't find the issue back though.
studio64_dsk4RgROYw.mp4