This repository was archived by the owner on Dec 1, 2024. It is now read-only.
remove WriteStream, replace in tests with level-ws#296
Closed
remove WriteStream, replace in tests with level-ws#296
Conversation
Member
|
lgtm! |
Member
|
lgtm I have tested this code with this PR Level/level-ws#2. I suggest we merge it and release a new version of Thoughts? |
Member
|
Oh right. The functional tests aren't passing. Missed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is against 1.0.0-wip / #289 / @kesla
I've removed write-stream.js but have left the tests intact by using level-ws but it'll depend on 1.0.0 if & when Level/level-ws#2 is merged.
The only part missing is the fstream stuff for functional tests. I'll work on that next.