Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bump: deepspeed to be 0.16 #21194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

bump: deepspeed to be 0.16 #21194

wants to merge 3 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 10, 2025 •
edited by github-actions bot
Loading

What does this PR do?

required for #20461 (comment)

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21194.org.readthedocs.build/en/21194/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Sep 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025 •
edited
Loading

🌩️ Required checks status: Pending 🟡

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success ✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

🟡 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, pytorch, 3.10, L4_X_2) in_progress ⌛
pytorch.yml / Lit Job (nvidia/cuda:12.6.3-runtime-ubuntu22.04, lightning, 3.12, L4_X_2) in_progress ⌛
pytorch.yml / Lit Job (nvidia/cuda:12.6.3-runtime-ubuntu22.04, pytorch, 3.12, L4_X_2) in_progress ⌛

These checks are required after the changes to requirements/pytorch/strategies.txt, requirements/fabric/strategies.txt.

🟡 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) in_progress ⌛
benchmark.yml / Lit Job (pytorch) in_progress ⌛

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to requirements/fabric/strategies.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to requirements/pytorch/strategies.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success ✅

These checks are required after the changes to requirements/fabric/strategies.txt.

🟡 lightning_fabric: lit GPU
Check ID Status
fabric.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, fabric, 3.10, L4_X_2) in_progress ⌛
fabric.yml / Lit Job (nvidia/cuda:12.6.3-runtime-ubuntu22.04, fabric, 3.12, L4_X_2) in_progress ⌛
fabric.yml / Lit Job (nvidia/cuda:12.6.3-runtime-ubuntu22.04, lightning, 3.12, L4_X_2) in_progress ⌛

These checks are required after the changes to requirements/fabric/strategies.txt.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

🟢 install
Check ID Status
install-pkg-guardian success ✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (e088694) to head (e26cd46).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #21194    +/-   ##
========================================
- Coverage      87%      87%    -1%     
========================================
  Files         269      269            
  Lines       23688    23688            
========================================
- Hits        20666    20533   -133     
- Misses       3022     3155   +133

@Borda Borda mentioned this pull request Sep 10, 2025
Open
7 tasks
@Borda Borda marked this pull request as draft September 16, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Borda @tchaton @SkafteNicki @justusschock