Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 12, 2025

What does this PR do?

have this failing github workflow https://github.com/Lightning-AI/pytorch-lightning/actions/runs/17683035964/job/50270918592?pr=21196 but the same checkout is used for the other two passes and also all was pissing earlier today with the very same commit

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21208.org.readthedocs.build/en/21208/

@github-actions github-actions bot added docs Documentation related ci Continuous Integration labels Sep 12, 2025
Copy link
Contributor

github-actions bot commented Sep 12, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested a review from Copilot September 12, 2025 21:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the documentation build workflow to debug a failing checkout issue in GitHub Actions by enabling recursive submodule cloning and LFS (Large File Support) for all documentation builds instead of only for PyTorch-specific builds.

  • Enables recursive submodules and LFS for all package builds (fabric and pytorch) instead of conditionally enabling them only for pytorch
  • Simplifies the checkout configuration by removing conditional logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants