minimum and maximum value can also be negative values#4
Merged
LinuxDevon merged 1 commit intoLinuxDevon:masterfrom Jan 5, 2023
Merged
minimum and maximum value can also be negative values#4LinuxDevon merged 1 commit intoLinuxDevon:masterfrom
LinuxDevon merged 1 commit intoLinuxDevon:masterfrom
Conversation
Contributor
Author
Owner
|
@Murmele looks good and thank you! |
LinuxDevon
approved these changes
Jan 5, 2023
Contributor
Author
Yes maybe splitting up and the concatenating to one const string. I think the compiler will optimize it out then |
Contributor
Author
|
@LinuxDevon if it is fine for you, I can do that because I found at least one more issues |
Owner
|
@Murmele that is fine with me. Appreciate the help! I am planning on adding in an action to run the test suite on PR. If you don't mind can you add some more edge case test for those? |
Contributor
Author
|
@LinuxDevon perfect I will create some tests next days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example: