Added precise python backtick check #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but I do not think having python identifier is a robust solution for this. I recommend using custom extraction format to ensure reliability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We find a bug in extraction_utils.py where the code block is identified as the content within the last pair of backticks, specifically handled by this logic:
However, this logic is vulnerable because whenever the model decides to put a text summary as a markdown component after the solution code, the summary will be extracted, not the python code.
To fix this, we changed the extraction logic to look specifically for the last pair of backticks with python tags, ensuring that python code is extracted. Only when no python code is detected do we fall back to the original implementation.