Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Support for Safely Elevating Administrator Privileges #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 27, 2023
Merged

Add Support for Safely Elevating Administrator Privileges #1036

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1da92fb
Adds support for elevating processes that require it. It will retry t…
Nonary Mar 13, 2023
8bf2882
Removing debug code
Nonary Mar 13, 2023
33b7f1f
Placing code inside IF block now, since it wa previously doing work r…
Nonary Mar 13, 2023
65c22a2
Updated the code to utilize an elevation tool and added explanation t…
Nonary Mar 16, 2023
74ae9ac
I guess these are the lint fixes?
Nonary Mar 16, 2023
7151745
Adding line break
Nonary Mar 16, 2023
cce7bbe
Removing trailing space
Nonary Mar 16, 2023
449801c
Adding documentation
Nonary Mar 17, 2023
619b9ca
removing unused import
Nonary Mar 17, 2023
7f17670
sorting the headers in alphebetical order
Nonary Mar 17, 2023
45983bb
Improving the grammar of this code comment.
Nonary Mar 17, 2023
8aef4e2
Shifting it closer alphabetically instead of chronologically
Nonary Mar 17, 2023
b5b01f2
Changing null to nullptr
Nonary Mar 17, 2023
8e9979c
Remove extra line
Nonary Mar 17, 2023
0beb940
Final touches for nullptr changes
Nonary Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improving the grammar of this code comment.
  • Loading branch information
@Nonary @ReenigneArcher
Nonary authored and ReenigneArcher committed Mar 27, 2023
commit 45983bb0559b34531a9bac3907c6189e4d7022e9
9 changes: 4 additions & 5 deletions src/platform/windows/misc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,11 +477,10 @@ bp::child run_unprivileged(const std::string &cmd, boost::filesystem::path &work
std::wstring elevated_command = L"tools\\elevator.exe ";
elevated_command += wcmd;

// For security reasons, Windows enforces that an application can only have one "interactive thread," responsible for processing input from the user and managing the user interface (UI).
// Since UAC prompts are interactive, we can't have a UAC prompt while Sunshine is already running because it would block the thread.
// To workaround this issue, we will launch a separate process that will elevate the command which will prompt for user to confirm the elevation.
// This is our intended behavior, to require interaction before elevating the command.

// For security reasons, Windows enforces that an application can have only one "interactive thread" responsible for processing user input and managing the user interface (UI).
// Since UAC prompts are interactive, we cannot have a UAC prompt while Sunshine is already running because it would block the thread.
// To work around this issue, we will launch a separate process that will elevate the command, which will prompt the user to confirm the elevation.
// This is our intended behavior: to require interaction before elevating the command.
ret = CreateProcessAsUserW(shell_token,
NULL,
(LPWSTR)elevated_command.c_str(),
Expand Down