Recommendation Breakdown and Auto Bolus Carbs - PR against main #2277
+1,683
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup breakdown logic and add support for max bolus in breakdown
Sync to dev 3.5.0
Avoid calculating BG correction for ABC as it's not needed.
Needed e.g. when changing ABC Active by Default
By definition missing insulin always participates in exclusion calculation. Therefore, if there is an exclusion row, this means that the missing insulin was completely used up and should be marked as excluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As dev is largely waiting on tidepool-main merges, this PR is targeting main so as to enable others to easily test.
The original PR (against dev) is: #2148