Prune requirements #261
Merged
Prune requirements #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @cbrnr! Thanks for the input! It appears like |
|
Cool, thanks for the quick response! Regarding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just did
pip install wfdband noticed that there are some dependencies that can probably be removed. The packagesklearnis not a real package (you wantscikit-learn) so it should be removed. I've also movednosetoextras_requirebecause it is not required for normal usage (I've kept it inrequirements.txtthough). Finally, I thinksixis never used in the project so I've removed it. Not sure if there are more unused dependencies, but these are probably the most important fixes. Let me know what you think.