Add options to set position of notification (Top/Bottom)#29
Open
iNima wants to merge 1 commit into
Open
Conversation
…ss animation behaviors based on it. (Top/Bottom)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @toblerpwn ,
I wanted to show the notification at bottom of screen.
Sometimes we face with a situation where it would be better to show notification at the bottom for example when It should remain on screen for a period of time. In some advance example we can show some count down or similar things as a notification. So it should not cover other UIs at the top of the screen.
I added an option to set notification position type.
Now developers can decide about showing notification at top or bottom.
Changing the position was not enough because all show and dismiss animations were implemented based on top position. So I changed all of them to be suitable and aligned based on position of notification.
All three animations now are shown and dismissed from/to direction that is appropriate for top/bottom notification.
I attached some screenshots, too.
Please try it and tell me your opinion about that. I tried to write the code in a pattern to be in sync with other parts of the source.
Regards,
Nima Azimi