Change encoding of OpenSSL::HMAC.digest result to binary #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this should fix #49 .
With version 0.12, simple script using net-ssh like following fails with an error
The
packet_stream.rb:146
is likeThe encoding of
encrypted_data
isASCII-8BIT
, and encoding ofmac
isUTF-8
.mac
is generated at 3 lines above.client
is an instance ofNet::SSH::Transport::HMAC::*
(depends algorithm). All those classes are inherited fromNet::SSH::Transport::HMAC::Abstract
, andNet::SSH::Transport::HMAC::Abstract#digest
simply callsOpenSSL::HMAC.digest
like:Thus, I change the encoding of
OpenSSL::HMAC.digest
return value. Indeed, MRI returnsBINARY
.