move default modules from /modules/default to /defaultmodules#4019
move default modules from /modules/default to /defaultmodules#4019rejas merged 3 commits intoMagicMirrorOrg:developfrom
Conversation
|
I understand that a few third-party modules would also need to be modified, such as MMM-Config and MMM-RemoteControl. Perhaps it's also possible to store the new relative path in |
|
I prefer defaultmodules as well there is nothing else we would put in the default folder, right? |
yes, everything which is now under 
|
|
No. I meant is it conceivable that there are other entities besides modules we would put in a folder called default I understand the modules css, separating ours from users more |
|
yes, the Another approach could be to do everything into
The last approach would allow the standard modules to remain in their current location, but I think that would be a massive change for every user, so I immediately dismissed that idea. |
|
I have updated MMM-Config to handle either default modules location |
|
from my side ready to merge |
This is another change to cleanup structure, already mentioned in #4019 (comment) After separating default and 3rd-party modules this PR moves the `custom.css` from the mm-owned directory `css` into user owned directory `config`. It has a built-in function which moves the `css/custom.css` to the new location `config/custom.css` (if the target not exists). Let me know if there's a majority in favor of this change.
Since the project's inception, I've missed a clear separation between default and third-party modules.
This increases complexity within the project (exclude
modules, but notmodules/default), but the mixed use is particularly problematic in Docker setups.Therefore, with this pull request, I'm moving the default modules to a different directory.
I've chosendefault/modules, but I'm not bothered about it;defaultmodulesor something similar would work just as well.Changed to
defaultmodules.Let me know if there's a majority in favor of this change.