Fix2658 #2757
Merged
Fix2658 #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default card style is now MaterialDesignElevatedCard and a new alternative style, MaterialDesignOutlineCard added.
Also ensured the DoubleToCornerRadiusConverter returns a CornerRadius of 0 for negative values.
|
I was a little unsure of whether I should merge two nested Borders into one, but I left it as 2 which were "copied" from the Elevated style and modified to not use the drop shadow, but have a solid border instead. |
Keboo
approved these changes
Jul 5, 2022
|
@nicolaihenriksen Thank you for your contribution, it's really appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2658
Split Card template into 2 styles: Elevated and Outlined.
For the outlined style, I was unsure whether to add a new color or use an existing one. It was not 100% clear where I should add that color if I wanted it, so I opted to reuse the MaterialDesignDivider brush which seems to resemble the dimmed look from the material.io design pretty well.
Added unit test for newly added converter and UI tests for newly added card style.
In order to get the UI tests to run, I had to include Generic.xaml in the merged resources dictionary. I think this "happens automatically" when running a WPF app, but for the test it seemed necessary to add manually. Perhaps this is something that should be included in the XAMLTest library instead?