Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

viveleltsi
Copy link
Contributor

Preface

Hello everyone and happy new year,

This is my first contribution to a GitHub project and I hope it's the right way to do it.
Feel free to give me some feedback or asking for changes if required.

Thanks you =)

Description

This pull request create a new slider to better match the MaterialDesign 3 guideline. It's a small change required in one of my project and I decided to share it as I think it's usefull. The only change is the height of the active track who need to match the track height. Here's the md3 slider spec :

image

I follow some guideline found here and there on this repo about handeling the version 3 of material design:

  • Creating a new themes for specific md3 element
  • Adding to the md3 default theme
  • Update the demo project

Result on the demo app :
image

Current master of the demo app :
image

Changes Made

  • Create a new slider theme md3
    • Changing the height of the selected line (activeTrack) of the slider line to match the md3 guideline (So the activeTrack and the Track have the same height : 4 )
  • Use this new slider them on the demo app

Related Issues

None

Additional Notes

If theses changes are validate it could be possible to do the same for the range slider (on project MaterialDesignThemes.MahApps ). But this project does not include a md3 theme so you'll have to decide if a default md3 theme file should be created or if the current RangeSlider should be updated.

@viveleltsi viveleltsi changed the title Create a new slider them to match the md3 guideline Create the slider theme for md3 guideline Jan 8, 2024
@Keboo
Copy link
Member

Keboo commented Jan 11, 2024

This is really great work. Thank you for submitting it.
If you would like to do one for MahApps sliders that would be great. I would probably make a separate page, and link in the MD3 style resource dictionary directly.

@Keboo Keboo added this to the 5.0.0 milestone Jan 11, 2024
@Keboo Keboo added enhancement release notes Items are likely to be highlighted in the release notes. labels Jan 11, 2024
@Keboo Keboo merged commit dba2cf5 into MaterialDesignInXAML:master Jan 11, 2024
adrbarros added a commit to adrbarros/MaterialDesignInXamlToolkit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement release notes Items are likely to be highlighted in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants