You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aligns the NumericUpDown style to the one of other controls (closes#3614)
Tasks
Add to fields line up
Validation Style
Floating Hint
Helper Text
Suffix
Prefix
Breaking
Currently IncreaseContent and DecreaseContent are ignored since this two values should be the same as in TimePicker, not changable.
Should we use IncreaseContent and DecreaseContent or remove it. I would prefer to remove it and use it predefined as in TimePicker. If we ignore both properties, then we have to remove it from code before merging
michaelmairegger
changed the title
[Work in progress] Align NumericUpDown style with other controls
Align NumericUpDown style with other controls
Jun 24, 2024
Should we use IncreaseContent and DecreaseContent or remove it. I would prefer to remove it and use it predefined as in TimePicker. If we ignore both properties, then we have to remove it from code before merging
First of all, nice work!
Regarding your comment: I believe we should use them. We should default them to the PackIcon values they have currently, but I see no reason not to let someone manipulate them from the outside. For example if they want up/down arrows instead of +/-.
As for your comment about the TimePicker I think it would also make sense there to make the content configurable; thus could be considered a bug or a missing feature.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the NumericUpDown style to the one of other controls (closes #3614)
Tasks
Breaking
Currently IncreaseContent and DecreaseContent are ignored since this two values should be the same as in TimePicker, not changable.