-
Notifications
You must be signed in to change notification settings - Fork 185
Android GUI: Dark mode rework + migrate deprecated APIs #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for this proposal, I am fine with it. |
94ef66c to
a454133
Compare
|
I have resolved almost all warnings in Android Studio. Also migrated a few deprecated APIs to newer APIs. Updated the first post accordingly. What remains is usage of deprecated AsyncTask in ReportListActivity. Also should probably migrate the main menu to MenuProvider as well since already using that for the fragment menu. These two likely requires more work since that part of codes looks complex and has high risk of breaking functionality so I did not touch them. |
|
Migrated the deprecated AsyncTask to Kotlin Coroutines as well. Not as difficult as I thought. |
|
May want to review the warnings in .gradle files regarding deprecated 'proguard-android.txt' and some outdated dependencies. I did not touch those as they may break stuff or cause need to increase minSdkVersion. |
Match the English version. `subscription_detail_text` is not supposed to contain format specifiers or `%PRICE%` placeholder. It will not be replaced and will cause build warning.
This PR contains a suggested implementation for reworking the dark mode of the MediaInfo Android app.
Changes:
Reason:
Other changes in this PR not related to dark mode:
These non-dark-mode-related changes (other than the English correction) should not have any visible changes to users of the app.