re-run resolve function for columns containing dot in the name #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should solve #505
The issue when exporting was both export and re-render are happening in the single request. The 2nd time query is built, it starts fresh (from builder method) but columns are already resolved.
Column doesn't have any join info stored in it so the join is missing and thus generating Unknown column error. It is because resolveColumnName will change query directly.
That being said, there is a workaround for this bug. If we define builder function in our class, and we do a manual join there, then everything will be fine. But still, I think this one should be solved in the library.