Codestin Search App

edwinyyyu · 2026-05-08T21:51:23Z

Purpose of the change

Alternative to #1304.
#1304 added EventMemory as a parallel memory subsystem highly exposed via API.
We want to make large changes only after careful design, so this PR instead adds EventMemory as a backend for the existing long-term memory, with minimal behavioral differences.

Description

No chunking/segmentation, old API.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (does not change functionality, e.g., code style improvements, linting)
Documentation update
Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
Security (improves security without changing functionality)

Testing

Checklist

Maintainer Checklist

Confirmed all checks passed
Contributor has signed the commit(s)
Reviewed the code
Run, Tested, and Verified the change(s) work as expected

Signed-off-by: Edwin Yu <[email protected]> Example configs Signed-off-by: Edwin Yu <[email protected]>

Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu · 2026-05-12T00:22:54Z

User-supplied filterable_metadata can clobber system fields → cross-producer / cross-session impersonation

  long_term_memory.py:495-508: properties.update(episode.filterable_metadata) runs after _producer_id, _session_key, _episode_uid
  etc. are set. Any colliding key from the client wins. There is no key filter anywhere in the path from EpisodeEntry.metadata →
  episodic_memory.py:223 → episode.filterable_metadata → _episode_to_event.

  The test test_episode_to_event.py:134-144 literally asserts this behavior:
  filterable_metadata={"_producer_id": "shouldnt-overwrite"}
  ...
  assert event.properties["_producer_id"] == "shouldnt-overwrite"
  # comment: "If we ever want to protect system fields ... we'll need an explicit validator"

  A client sending {"_producer_id": "victim", "_session_key": "other-session"} gets indexed under those spoofed identities.
  search_scored(property_filter=producer_id="victim") then surfaces the attacker's content under the victim's identity, and the
  dedup-by-_episode_uid (long_term_memory.py:294-299) collapses results across spoofed and real episode uids. The declarative path is
   safe because it mangles user keys with a metadata. prefix — only the event path regressed.

Signed-off-by: Edwin Yu <[email protected]>

Copilot

Pull request overview

This PR wires EventMemory as an alternative backend for the existing long-term episodic memory, behind a new backend discriminator ("declarative" | "event"). Legacy configs without a backend field continue to deserialize as declarative (backwards compatible), while the configuration wizard now generates event-backed configs by default and offers a vector-store selection (Qdrant / SQLite-USearch / sqlite-vec). The LongTermMemory facade is refactored into a dispatcher between two backend params types, exposing a slimmer public surface (search_scored, delete_episodes, drop_session_partition) and removing the older search / get_episodes / get_matching_episodes / delete_matching_episodes / sanitize_property_filter / episode_from_declarative_memory_episode methods.

Changes:

Introduce a discriminated LongTermMemoryConf (Declarative vs Event) and corresponding API spec / response / update fields (backend, vector_store, segment_store, properties_schema), with property-type validation at request time.
Add EventMemory-backed long-term memory: episode-to-event translation, deterministic uuid5 mapping, reserved-key rejection, filter-field validation, metric-aware score thresholding, and drop_session_partition for partition lifecycle.
Update the resource manager to construct/cache segment stores from SQL engines; update the configuration wizard, sample configs, server defaults, and clients (Python SDK + tests) to support the new backend.

Reviewed changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 20 comments.

Show a summary per file

File	Description
`sample_configs/episodic_memory_config.{cpu,gpu,nebula}.sample`	Document the new event backend and Qdrant/SQLite vector-store options.
`packages/server/src/memmachine_server/server/api_v2/router.py`	Translate v2 `ProjectConfig` ⇆ `LongTermMemoryConfPartial`; expose event-backend fields.
`packages/server/src/memmachine_server/server/api_v2/config_service.py`	Backend-flip handling; surface event-backend fields in config responses.
`packages/server/src/memmachine_server/server/api_v2/config_router.py`	Forward new event-backend fields on PUT.
`packages/server/src/memmachine_server/main/memmachine.py`	Backend-aware LTM default resolution; narrow exception catch.
`packages/server/src/memmachine_server/installation/configuration_wizard.py`	Default to event backend + interactive vector-store selection.
`packages/server/src/memmachine_server/episodic_memory/long_term_memory/`	New backends, params, service-locator helpers, facade refactor.
`packages/server/src/memmachine_server/episodic_memory/event_memory/segmenter/passthrough_segmenter.py`	New passthrough segmenter implementation.
`packages/server/src/memmachine_server/episodic_memory/event_memory/segment_store/sqlalchemy_segment_store.py`	Map bare filter fields to `_<field>` instead of raising.
`packages/server/src/memmachine_server/episodic_memory/episodic_memory.py`	Use `drop_session_partition()` on delete-session.
`packages/server/src/memmachine_server/common/resource_manager/{,resource_manager}.py`	Add `get_segment_store` and `get_episode_storage` interfaces.
`packages/server/src/memmachine_server/common/configuration/episodic_config.py`	Discriminated LTM config, new sub-configs, merge resolution.
`packages/common/src/memmachine_common/api/{spec,config_spec}.py`	New backend / event-backend fields and `properties_schema` validation.
`packages/client/src/memmachine_client/{client,config,project}.py`	Plumb new event-backend params through SDK.
`packages/server/server_tests/`, `packages/client/client_tests/`	New / updated tests for backend switching, event wiring, wizard prompts.
`.github/workflows/{installation,test-server,test-python-client}.yml`	Install all local `memmachine_*` wheels by direct path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu force-pushed the wire_event_memory_backend branch from f570bd7 to 6e45f17 Compare May 8, 2026 21:52

edwinyyyu changed the title ~~Claude initial wiring~~ Wire EventMemory as backend for LongTermMemory May 8, 2026

Claude initial wiring

da58952

Signed-off-by: Edwin Yu <[email protected]> Example configs Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu force-pushed the wire_event_memory_backend branch from 280f09d to da58952 Compare May 8, 2026 22:11

edwinyyyu requested a review from malatewang May 8, 2026 22:11

edwinyyyu marked this pull request as ready for review May 8, 2026 22:17

edwinyyyu added 2 commits May 8, 2026 15:35

Add tests

bb8192e

Signed-off-by: Edwin Yu <[email protected]>

Add overfetch

8f6fb0d

Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu force-pushed the wire_event_memory_backend branch from 456bc43 to 8f6fb0d Compare May 8, 2026 22:41

edwinyyyu marked this pull request as draft May 8, 2026 23:33

Config updates

0999aec

Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu force-pushed the wire_event_memory_backend branch 4 times, most recently from 4cd2ff6 to 501f052 Compare May 9, 2026 00:45

edwinyyyu mentioned this pull request May 9, 2026

[Feat]: SQL filter compilation improvement #1380

Closed

Fixes

4704400

Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu force-pushed the wire_event_memory_backend branch from 501f052 to 4704400 Compare May 9, 2026 00:54

malatewang approved these changes May 11, 2026

View reviewed changes

Comment thread packages/server/src/memmachine_server/episodic_memory/long_term_memory/long_term_memory.py Outdated

Fix CI

fcd62a9

Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu force-pushed the wire_event_memory_backend branch from 6d11900 to fcd62a9 Compare May 11, 2026 20:20

edwinyyyu marked this pull request as ready for review May 11, 2026 20:56

edwinyyyu added this to the v0.3.9 milestone May 11, 2026

edwinyyyu marked this pull request as draft May 12, 2026 00:22

edwinyyyu and others added 4 commits May 11, 2026 17:24

Make backend configurable from client

1ce6361

Signed-off-by: Edwin Yu <[email protected]>

Fix impersonation security problem

728a820

Signed-off-by: Edwin Yu <[email protected]>

Address AI review, fix latent bugs

492d67e

Signed-off-by: Edwin Yu <[email protected]>

Merge branch 'main' into wire_event_memory_backend

4e92a05

edwinyyyu marked this pull request as ready for review May 13, 2026 23:00

sscargal requested review from Copilot and srinivas-aji May 14, 2026 16:29

Copilot started reviewing on behalf of sscargal May 14, 2026 16:29 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Get episodes in batch

d61963e

Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu force-pushed the wire_event_memory_backend branch 3 times, most recently from 632bc8e to 56eb8bc Compare May 14, 2026 20:38

Address review

a35a144

Signed-off-by: Edwin Yu <[email protected]>

edwinyyyu force-pushed the wire_event_memory_backend branch from 56eb8bc to a35a144 Compare May 14, 2026 20:43

Merge branch 'main' into wire_event_memory_backend

7b79476

malatewang merged commit a5cf59d into MemMachine:main May 14, 2026
42 of 44 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wire EventMemory as backend for LongTermMemory#1395

Wire EventMemory as backend for LongTermMemory#1395
malatewang merged 13 commits into
MemMachine:mainfrom
edwinyyyu:wire_event_memory_backend

edwinyyyu commented May 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

edwinyyyu commented May 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

edwinyyyu commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of the change

Description

Type of change

Testing

Checklist

Maintainer Checklist

Uh oh!

Uh oh!

edwinyyyu commented May 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

edwinyyyu commented May 8, 2026 •

edited

Loading