Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Scormave
Copy link
Contributor

@Scormave Scormave commented Jun 2, 2023

If there is an interface declaration with Union attributes, types that are specified aren't collected for formatter generation. But, in the same time, if there is Union attributes above generic type declaration, types from them will be collected (CollectGenericUnion).

@Scormave Scormave changed the base branch from master to develop June 2, 2023 07:09
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Might I prevail upon you to add a test for this case?

@Scormave
Copy link
Contributor Author

@AArnott Yes, of course. Added test case.

@gsino
Copy link

gsino commented Jun 29, 2023

I previously submitted a pull request for a fix for the same issue.
#1322

@AArnott
Copy link
Collaborator

AArnott commented Aug 13, 2023

@gsino I'm sorry your PR didn't get traction earlier. Thanks for contributing though!

Thanks for the added test @Scormave!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants