Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fixing issue with backing field naming and serialization failing #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2024
Merged

fixing issue with backing field naming and serialization failing #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4160966
fixing issue with backing field naming and serialization failing
epitka-sg Mar 8, 2024
dfe2717
Remove commented code
AArnott Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Resolvers/DynamicObjectResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2019,19 +2019,6 @@ bool AddEmittableMemberOrIgnore(bool isIntKeyMode, EmittableMember member, bool

if (len != 0)
{
if (len != 1)
{
if (ctorEnumerator != null)
{
ctor = null;
break;
}
else
{
throw new MessagePackDynamicObjectResolverException("duplicate matched constructor parameter name:" + type.FullName + " parameterName:" + item.Name + " parameterType:" + item.ParameterType.Name);
}
}

paramMember = hasKey.First().Value;
if (item.ParameterType.IsAssignableFrom(paramMember.Type) && paramMember.IsReadable)
{
Expand Down
47 changes: 47 additions & 0 deletions tests/MessagePack.Tests/ContractlessStandardResolverConstructorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,43 @@ public TestConstructor2(int x, int y, int z)
}
}

public class TestConstructor3
{
private Guid x;
private Guid y;

public TestConstructor3(Guid x, Guid y)
{
this.x = x;
this.y = y;
this.CalledConstructorParameterCount = 2;
}

public int CalledConstructorParameterCount { get; }

public Guid X
{
get => this.x;
set => this.x = value;
}

public Guid Y
{
get => this.y;
set => this.y = value;
}
}

[Fact]
public void UseConstructor3()
{
var ctor = new TestConstructor3(Guid.NewGuid(), Guid.NewGuid());
var bin = MessagePackSerializer.Serialize(ctor, ContractlessStandardResolverAllowPrivate.Options);
var r = MessagePackSerializer.Deserialize<TestConstructor3>(bin, ContractlessStandardResolverAllowPrivate.Options)!;

r.CalledConstructorParameterCount.Is(2);
}

[Fact]
public void UseConstructor()
{
Expand All @@ -95,6 +132,16 @@ public void UseConstructor()
r.CalledConstructorParameterCount.Is(3);
}

[Fact]
public void UseConstructor2()
{
var ctor = new TestConstructor1(10, 20, 30);
var bin = MessagePackSerializer.Serialize(ctor, ContractlessStandardResolver.Options);
var r = MessagePackSerializer.Deserialize<TestConstructor1>(bin, ContractlessStandardResolver.Options);

r.CalledConstructorParameterCount.Is(3);
}

[Fact]
public void IgnorePropertiesWithoutConstructorArgument()
{
Expand Down