Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

AlanLiu90
Copy link
Contributor

Fix #1925

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

As a suggestion for a follow-up change: if you want C# 9 to continue to be supported rather than regress by accident repeatedly, change the test helper class we use to compile the emitted code with C# 9 instead of whatever the latest is. That way, future regressions will cause tests to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants