Reconcile AllowPrivate behavior #1990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs on a non-public member Also report MsgPack011 only when a private member is to be serialized.
Update `DynamicObjectResolver` - to honor the new attribute property. This means that types that require private members to be serialized no longer must ask the application to use `DynamicObjectResolverAllowPrivate`, because the attribute will switch the ordinary resolver into AllowPrivate mode for that particular type. Update the source generated formatters: - to not require partial types for serializing `protected internal` members. - to only serialize public members in map mode, or all members when the new attribute property is `true`. Update the analyzer code fix provider - to require non-public members to be attributed when the new attribute property is set to `true`. Update tests - several new tests added - map mode tests that used `internal` were changed either to `public` or to use the new attribute property (somewhat arbitrarily) in order to keep the tests passing.
While source generators don't require it, it makes a real difference when using `DynamicObjectResolver` (which is the default, when a source generated formatter isn't found). This analyzer comes with a code fix provider. Plenty of tests (mostly testing source generated formatters) were using `internal` rather than `public` so with the analyzer enabled, a lot of test fixes were required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report MsgPack004 on non-public members only after an attribute appears on a non-public member
Also report MsgPack011 only when a private member is to be serialized.
Add
MessagePackObjectAttribute.AllowPrivatepropertyUpdate
DynamicObjectResolverDynamicObjectResolverAllowPrivate, because the attribute will switch the ordinary resolver into AllowPrivate mode for that particular type.Update the source generated formatters:
protected internalmembers.true.Update the analyzer code fix provider
true.Update tests
internalwere changed either topublicor to use the new attribute property (somewhat arbitrarily) in order to keep the tests passing.Fix missing analyzer docs
Add MsgPack015 analyzer to encourage use of new
AllowPrivatepropertyWhile source generators don't require it, it makes a real difference when using
DynamicObjectResolver(which is the default, when a source generated formatter isn't found).This analyzer comes with a code fix provider.
Plenty of tests (mostly testing source generated formatters) were using
internalrather thanpublicso with the analyzer enabled, a lot of test fixes were required.Closes #1899