Fix source generator, don't generate when abstract/interface is not union #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the Analyzer only enters the analysis path when in the IsGeneratingSource state, it cannot recognize this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2101
The generation of incorrect source code is interfering with other operations.
Originally, the v2 dynamic generation wasn't generating formatters,
and v3 is also reporting validation issues.
By the way,
IsGeneratingSourceseems like a bad approach.Moreover, the Analyzer isn't responding in the development environment - is it actually working...?
Also, while this should be in a separate PR, when SuppressSourceGeneration is enabled, it seems better to terminate the type search.