allow DynamicGenericResolver to StandardResolver in DynamicAssembly.AvoidDynamicCode #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current Unity's IL2CPP Full Generic Sharing, MakeGenericType works in many cases.
Therefore, it can likely be enabled even with AvoidDynamicCode.
https://unity.com/blog/engine-platform/il2cpp-full-generic-sharing-in-unity-2022-1-beta
Regarding NativeAOT, we should fundamentally reconsider the strategy.
In any case, since this Resolver becomes the endpoint when AvoidDynamicCode is used, enabling it wouldn't make a difference (either way it will throw an exception - whether it's because the Formatter wasn't found or because of an invalid MakeGenericType call).