Thanks to visit codestin.com
Credit goes to github.com

Skip to content

v12.0.0 release #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brad-decker merged 3 commits into from
Jul 7, 2021
Merged

v12.0.0 release #515

brad-decker merged 3 commits into from
Jul 7, 2021

Conversation

@brad-decker
Copy link
Contributor

@brad-decker brad-decker commented Jul 7, 2021

proposed changelog:

[12.0.0] - 2021-07-07

Added

  • Added GasFeeController to provide gas fee estimates #494

Changed

  • BREAKING: Added chainId support to TokenRatesControllers #476
    • The breaking change here is that TokenRatesController constructor now requires a onNetworkStateChange listener
  • Added iconUrl to Token type in TokenListController #512

@brad-decker brad-decker mentioned this pull request Jul 7, 2021
Closed
@brad-decker brad-decker marked this pull request as ready for review July 7, 2021 18:58
@brad-decker brad-decker requested a review from a team as a code owner July 7, 2021 18:58
@wachunei
Copy link
Member

wachunei commented Jul 7, 2021

The required changes because of #476 are:

  • TokenRatesController constructor should receive a onNetworkStateChange listener subscription:

    new TokenRatesController({
  onAssetsStateChange: listener => assetsController.subscribe(listener),
  onCurrencyRateStateChange: listener =>
    this.controllerMessenger.subscribe(`${currencyRateController.name}:stateChange`, listener),
  onNetworkStateChange: listener => networkController.subscribe(listener)
})

wachunei
wachunei previously approved these changes Jul 7, 2021
View reviewed changes
Gudahtt
Gudahtt requested changes Jul 7, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one minor suggestion for the changelog. But more importantly, it doesn't seem valid. The reference link definitions at the bottom have not been updated.

Edit: shameless plug for #511 😅 That would have caught this problem.

@brad-decker @Gudahtt
Update CHANGELOG.md
6317f47 
Co-authored-by: Mark Stacey <[email protected]>
@brad-decker
Copy link
Contributor Author

brad-decker commented Jul 7, 2021 •
edited
Loading

Edit: shameless plug for #511 😅 That would have caught this problem.

Haha on it!

Gudahtt
Gudahtt reviewed Jul 7, 2021
View reviewed changes
CHANGELOG.md Outdated
## [Unreleased]

## [12.0.0] - 2021-07-07

Copy link
Member

@Gudahtt Gudahtt Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did all of these extra newlines come from 🤔 This would also fail validation.

Copy link
Contributor Author

@brad-decker brad-decker Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It came from prettier... i have to keep a .prettierignore file without committing it or its gets really opionated about .md files

Copy link
Contributor Author

@brad-decker brad-decker Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed 😓

Copy link
Member

@Gudahtt Gudahtt Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, interesting. It's omitted in yarn lint explicitly, but we don't have any ignore file committed.... maybe that's something we should consider 🤔 For anyone that runs prettier directly.

Copy link
Contributor Author

@brad-decker brad-decker Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think prettier plugin for vscode respects eslintrc, so if were to somehow move that setting into the .eslintrc it should be fine. Otherwise a prettierignore file is also good.

Gudahtt
Gudahtt approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 7912586 into main Jul 7, 2021
@brad-decker brad-decker deleted the release/v12.0.0 branch July 7, 2021 19:20
@brad-decker
Copy link
Contributor Author

brad-decker commented Jul 7, 2021

A new version of the package @metamask/controllers (12.0.0) was published at 2021-07-07T19:22:41.557Z from
[REDACTED]. The shasum of this package was afc36e6e8eb53133996b6e41dfc30d01c25ba9d9.

MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@brad-decker @Gudahtt @MajorLift
v12.0.0 release (#515)
a000fbc 
* v12.0.0 release

* Update CHANGELOG.md

Co-authored-by: Mark Stacey <[email protected]>

* update ref links

Co-authored-by: Mark Stacey <[email protected]>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@brad-decker @Gudahtt @MajorLift
v12.0.0 release (#515)
ca5ddd2 
* v12.0.0 release

* Update CHANGELOG.md

Co-authored-by: Mark Stacey <[email protected]>

* update ref links

Co-authored-by: Mark Stacey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@wachunei wachunei wachunei left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brad-decker @wachunei @Gudahtt