25.0.0 #673
Merged
25.0.0 #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks Guto! Going to wait for review from @Gudahtt before merge. |
Gudahtt
reviewed
Jan 10, 2022
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Looks good aside from that one typo!
Co-authored-by: Mark Stacey <[email protected]>
Contributor
|
Thanks for pointing out the type @Gudahtt! Ready for another look! |
Gudahtt
approved these changes
Jan 10, 2022
Member
|
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* 25.0.0 * update changelog * Update CHANGELOG.md Co-authored-by: Mark Stacey <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Alex <[email protected]>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* 25.0.0 * update changelog * Update CHANGELOG.md Co-authored-by: Mark Stacey <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 25.0.0.
[25.0.0]
Added
checkAndUpdateSingleCollectibleOwnershipStatuson CollectiblesController, which contains the userAddress and chainId to check asset ownership against. If not included, the method will still check against the currently configured selectedAddress and chainId configured in the CollectiblesController (#672)getTokenStandardAndDetailsmethod on AssetsContractController which determines whether the input contract confirms to particular known token standard (ERC20,ERC721orERC1155) and returns the detected standard along with some key values/details about that the contract and/or specified token within that contract (#667)Changed
getAssetName->getERC721AssetNameandbalanceOfERC1155Collectible->getERC1155BalanceOf).