Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stanleyyconsensys
Copy link
Contributor

@stanleyyconsensys stanleyyconsensys commented Dec 1, 2025

Explanation

Due to the deprecation of MegaETH testnet v1 (chainId 0x18c6)

This PR Adds MegaETH Testnet V2 (chainId 0x18c7) across constants/types and default custom networks.

Add megaeth-testnet-v2 to controller-utils constants/types:

  • BuiltInNetworkName,
  • ChainId (0x18c7),
  • NetworksTicker,
  • BlockExplorerUrl,
  • NetworkNickname,
  • BUILT_IN_NETWORKS, and BUILT_IN_CUSTOM_NETWORKS_RPC

Include megaeth-testnet-v2 in NetworkController:

  • getDefaultCustomNetworkConfigurationsByChainId and AdditionalDefaultNetwork type.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Adds megaeth-testnet-v2 (chainId 0x18c7) across constants/types and default custom networks; marks megaeth-testnet v1 as deprecated.

  • Controller Utils:
    • Add megaeth-testnet-v2 to BUILT_IN_NETWORKS, BUILT_IN_CUSTOM_NETWORKS_RPC (https://timothy.megaeth.com/rpc), BuiltInNetworkName, ChainId (0x18c7), NetworksTicker, BlockExplorerUrl (https://megaeth-testnet-v2.blockscout.com), and NetworkNickname.
    • Deprecate v1 megaeth-testnet references across BUILT_IN_CUSTOM_NETWORKS_RPC, CustomNetworkType, BuiltInNetworkName, ChainId, NetworksTicker, BlockExplorerUrl, NetworkNickname.
  • Network Controller:
    • Include ChainId['megaeth-testnet-v2'] in default custom networks via getDefaultCustomNetworkConfigurationsByChainId.
    • Extend AdditionalDefaultNetwork to allow 'megaeth-testnet-v2'.
    • Update changelog entries to document the new default custom network and details (URL, chain ID).

Written by Cursor Bugbot for commit fbe53bc. This will update automatically on new commits. Configure here.

@stanleyyconsensys stanleyyconsensys marked this pull request as ready for review December 1, 2025 07:26
@stanleyyconsensys stanleyyconsensys requested review from a team as code owners December 1, 2025 07:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for MegaETH Testnet v2 as a custom network and migrates Monad Testnet from a custom network to an Infura-supported network. The changes update network type definitions, chain IDs, RPC endpoints, block explorers, and corresponding test snapshots.

  • Adds megaeth-testnet-v2 to CustomNetworkType with chain ID 0x18c7 and deprecates the original megaeth-testnet
  • Moves monad-testnet from CustomNetworkType to InfuraNetworkType with chain ID 0x279f
  • Updates test snapshots to reflect the new Monad Testnet Infura network configuration

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/controller-utils/src/types.ts Adds monad-testnet to InfuraNetworkType, adds megaeth-testnet-v2 to CustomNetworkType with deprecation notices, and updates related enums (BuiltInNetworkName, ChainId, NetworksTicker, BlockExplorerUrl, NetworkNickname)
packages/controller-utils/src/constants.ts Adds RPC endpoint for megaeth-testnet-v2 and ticker symbol, updates BUILT_IN_NETWORKS configuration
packages/controller-utils/CHANGELOG.md Documents addition of monad-testnet to InfuraNetworkType
packages/network-controller/tests/NetworkController.test.ts Updates test snapshots to include Monad Testnet as an Infura network with expected configuration
packages/assets-controllers/src/TokenDetectionController.test.ts Adds Monad Testnet chain ID to token detection test expectations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stanleyyconsensys stanleyyconsensys changed the base branch from main to chore/move-monad-testnet December 1, 2025 07:27
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner December 1, 2025 07:50
Base automatically changed from chore/move-monad-testnet to main December 1, 2025 08:07
@stanleyyconsensys
Copy link
Contributor Author

@metamaskbot publish preview

@stanleyyconsensys
Copy link
Contributor Author

@metamaskbot publish preview

@stanleyyconsensys stanleyyconsensys self-assigned this Dec 1, 2025
@stanleyyconsensys
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "4.0.0-preview-2b2b3f4d",
  "@metamask-previews/accounts-controller": "35.0.0-preview-2b2b3f4d",
  "@metamask-previews/address-book-controller": "7.0.1-preview-2b2b3f4d",
  "@metamask-previews/analytics-controller": "0.0.0-preview-2b2b3f4d",
  "@metamask-previews/announcement-controller": "8.0.0-preview-2b2b3f4d",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-2b2b3f4d",
  "@metamask-previews/approval-controller": "8.0.0-preview-2b2b3f4d",
  "@metamask-previews/assets-controllers": "92.0.0-preview-2b2b3f4d",
  "@metamask-previews/base-controller": "9.0.0-preview-2b2b3f4d",
  "@metamask-previews/bridge-controller": "63.2.0-preview-2b2b3f4d",
  "@metamask-previews/bridge-status-controller": "63.1.0-preview-2b2b3f4d",
  "@metamask-previews/build-utils": "3.0.4-preview-2b2b3f4d",
  "@metamask-previews/chain-agnostic-permission": "1.2.2-preview-2b2b3f4d",
  "@metamask-previews/claims-controller": "0.2.0-preview-2b2b3f4d",
  "@metamask-previews/composable-controller": "12.0.0-preview-2b2b3f4d",
  "@metamask-previews/controller-utils": "11.16.0-preview-2b2b3f4d",
  "@metamask-previews/core-backend": "5.0.0-preview-2b2b3f4d",
  "@metamask-previews/delegation-controller": "2.0.0-preview-2b2b3f4d",
  "@metamask-previews/earn-controller": "11.0.0-preview-2b2b3f4d",
  "@metamask-previews/eip-5792-middleware": "2.0.0-preview-2b2b3f4d",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-2b2b3f4d",
  "@metamask-previews/eip1193-permission-middleware": "1.0.2-preview-2b2b3f4d",
  "@metamask-previews/ens-controller": "19.0.0-preview-2b2b3f4d",
  "@metamask-previews/error-reporting-service": "3.0.0-preview-2b2b3f4d",
  "@metamask-previews/eth-block-tracker": "15.0.0-preview-2b2b3f4d",
  "@metamask-previews/eth-json-rpc-middleware": "22.0.0-preview-2b2b3f4d",
  "@metamask-previews/eth-json-rpc-provider": "6.0.0-preview-2b2b3f4d",
  "@metamask-previews/foundryup": "1.0.1-preview-2b2b3f4d",
  "@metamask-previews/gas-fee-controller": "26.0.0-preview-2b2b3f4d",
  "@metamask-previews/gator-permissions-controller": "0.6.0-preview-2b2b3f4d",
  "@metamask-previews/json-rpc-engine": "10.2.0-preview-2b2b3f4d",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-2b2b3f4d",
  "@metamask-previews/keyring-controller": "25.0.0-preview-2b2b3f4d",
  "@metamask-previews/logging-controller": "7.0.1-preview-2b2b3f4d",
  "@metamask-previews/message-manager": "14.1.0-preview-2b2b3f4d",
  "@metamask-previews/messenger": "0.3.0-preview-2b2b3f4d",
  "@metamask-previews/multichain-account-service": "4.0.0-preview-2b2b3f4d",
  "@metamask-previews/multichain-api-middleware": "1.2.4-preview-2b2b3f4d",
  "@metamask-previews/multichain-network-controller": "3.0.0-preview-2b2b3f4d",
  "@metamask-previews/multichain-transactions-controller": "7.0.0-preview-2b2b3f4d",
  "@metamask-previews/name-controller": "9.0.0-preview-2b2b3f4d",
  "@metamask-previews/network-controller": "27.0.0-preview-2b2b3f4d",
  "@metamask-previews/network-enablement-controller": "4.0.0-preview-2b2b3f4d",
  "@metamask-previews/notification-services-controller": "21.0.0-preview-2b2b3f4d",
  "@metamask-previews/permission-controller": "12.1.1-preview-2b2b3f4d",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-2b2b3f4d",
  "@metamask-previews/phishing-controller": "16.1.0-preview-2b2b3f4d",
  "@metamask-previews/polling-controller": "16.0.0-preview-2b2b3f4d",
  "@metamask-previews/preferences-controller": "22.0.0-preview-2b2b3f4d",
  "@metamask-previews/profile-metrics-controller": "1.0.0-preview-2b2b3f4d",
  "@metamask-previews/profile-sync-controller": "27.0.0-preview-2b2b3f4d",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-2b2b3f4d",
  "@metamask-previews/remote-feature-flag-controller": "2.0.1-preview-2b2b3f4d",
  "@metamask-previews/sample-controllers": "4.0.0-preview-2b2b3f4d",
  "@metamask-previews/seedless-onboarding-controller": "7.0.0-preview-2b2b3f4d",
  "@metamask-previews/selected-network-controller": "26.0.0-preview-2b2b3f4d",
  "@metamask-previews/shield-controller": "3.1.0-preview-2b2b3f4d",
  "@metamask-previews/signature-controller": "37.0.0-preview-2b2b3f4d",
  "@metamask-previews/storage-service": "0.0.0-preview-2b2b3f4d",
  "@metamask-previews/subscription-controller": "5.2.0-preview-2b2b3f4d",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-2b2b3f4d",
  "@metamask-previews/transaction-controller": "62.3.1-preview-2b2b3f4d",
  "@metamask-previews/transaction-pay-controller": "10.2.0-preview-2b2b3f4d",
  "@metamask-previews/user-operation-controller": "41.0.0-preview-2b2b3f4d"
}

@stanleyyconsensys
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "4.0.0-preview-5dcbfa3d",
  "@metamask-previews/accounts-controller": "35.0.0-preview-5dcbfa3d",
  "@metamask-previews/address-book-controller": "7.0.1-preview-5dcbfa3d",
  "@metamask-previews/analytics-controller": "0.0.0-preview-5dcbfa3d",
  "@metamask-previews/announcement-controller": "8.0.0-preview-5dcbfa3d",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-5dcbfa3d",
  "@metamask-previews/approval-controller": "8.0.0-preview-5dcbfa3d",
  "@metamask-previews/assets-controllers": "93.1.0-preview-5dcbfa3d",
  "@metamask-previews/base-controller": "9.0.0-preview-5dcbfa3d",
  "@metamask-previews/bridge-controller": "64.0.0-preview-5dcbfa3d",
  "@metamask-previews/bridge-status-controller": "64.0.1-preview-5dcbfa3d",
  "@metamask-previews/build-utils": "3.0.4-preview-5dcbfa3d",
  "@metamask-previews/chain-agnostic-permission": "1.3.0-preview-5dcbfa3d",
  "@metamask-previews/claims-controller": "0.2.0-preview-5dcbfa3d",
  "@metamask-previews/composable-controller": "12.0.0-preview-5dcbfa3d",
  "@metamask-previews/controller-utils": "11.16.0-preview-5dcbfa3d",
  "@metamask-previews/core-backend": "5.0.0-preview-5dcbfa3d",
  "@metamask-previews/delegation-controller": "2.0.0-preview-5dcbfa3d",
  "@metamask-previews/earn-controller": "11.0.0-preview-5dcbfa3d",
  "@metamask-previews/eip-5792-middleware": "2.0.0-preview-5dcbfa3d",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-5dcbfa3d",
  "@metamask-previews/eip1193-permission-middleware": "1.0.3-preview-5dcbfa3d",
  "@metamask-previews/ens-controller": "19.0.0-preview-5dcbfa3d",
  "@metamask-previews/error-reporting-service": "3.0.0-preview-5dcbfa3d",
  "@metamask-previews/eth-block-tracker": "15.0.0-preview-5dcbfa3d",
  "@metamask-previews/eth-json-rpc-middleware": "22.0.0-preview-5dcbfa3d",
  "@metamask-previews/eth-json-rpc-provider": "6.0.0-preview-5dcbfa3d",
  "@metamask-previews/foundryup": "1.0.1-preview-5dcbfa3d",
  "@metamask-previews/gas-fee-controller": "26.0.0-preview-5dcbfa3d",
  "@metamask-previews/gator-permissions-controller": "0.7.0-preview-5dcbfa3d",
  "@metamask-previews/json-rpc-engine": "10.2.0-preview-5dcbfa3d",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-5dcbfa3d",
  "@metamask-previews/keyring-controller": "25.0.0-preview-5dcbfa3d",
  "@metamask-previews/logging-controller": "7.0.1-preview-5dcbfa3d",
  "@metamask-previews/message-manager": "14.1.0-preview-5dcbfa3d",
  "@metamask-previews/messenger": "0.3.0-preview-5dcbfa3d",
  "@metamask-previews/multichain-account-service": "4.0.0-preview-5dcbfa3d",
  "@metamask-previews/multichain-api-middleware": "1.2.5-preview-5dcbfa3d",
  "@metamask-previews/multichain-network-controller": "3.0.0-preview-5dcbfa3d",
  "@metamask-previews/multichain-transactions-controller": "7.0.0-preview-5dcbfa3d",
  "@metamask-previews/name-controller": "9.0.0-preview-5dcbfa3d",
  "@metamask-previews/network-controller": "27.0.0-preview-5dcbfa3d",
  "@metamask-previews/network-enablement-controller": "4.0.0-preview-5dcbfa3d",
  "@metamask-previews/notification-services-controller": "21.0.0-preview-5dcbfa3d",
  "@metamask-previews/permission-controller": "12.1.1-preview-5dcbfa3d",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-5dcbfa3d",
  "@metamask-previews/phishing-controller": "16.1.0-preview-5dcbfa3d",
  "@metamask-previews/polling-controller": "16.0.0-preview-5dcbfa3d",
  "@metamask-previews/preferences-controller": "22.0.0-preview-5dcbfa3d",
  "@metamask-previews/profile-metrics-controller": "1.0.0-preview-5dcbfa3d",
  "@metamask-previews/profile-sync-controller": "27.0.0-preview-5dcbfa3d",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-5dcbfa3d",
  "@metamask-previews/remote-feature-flag-controller": "3.0.0-preview-5dcbfa3d",
  "@metamask-previews/sample-controllers": "4.0.0-preview-5dcbfa3d",
  "@metamask-previews/seedless-onboarding-controller": "7.1.0-preview-5dcbfa3d",
  "@metamask-previews/selected-network-controller": "26.0.0-preview-5dcbfa3d",
  "@metamask-previews/shield-controller": "3.1.0-preview-5dcbfa3d",
  "@metamask-previews/signature-controller": "37.0.0-preview-5dcbfa3d",
  "@metamask-previews/storage-service": "0.0.0-preview-5dcbfa3d",
  "@metamask-previews/subscription-controller": "5.4.0-preview-5dcbfa3d",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-5dcbfa3d",
  "@metamask-previews/transaction-controller": "62.5.0-preview-5dcbfa3d",
  "@metamask-previews/transaction-pay-controller": "10.4.0-preview-5dcbfa3d",
  "@metamask-previews/user-operation-controller": "41.0.0-preview-5dcbfa3d"
}

* @deprecated Please use `megaeth-testnet-v2` instead.
*/
'megaeth-testnet': 'https://carrot.megaeth.com/rpc',
'megaeth-testnet-v2': 'https://timothy.megaeth.com/rpc',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stanleyyconsensys Is there any reason we wouldn’t simply update the previous one? Or were you concerned this might introduce a breaking change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, I see now that this isn’t the only change; the chainId is also being updated.

Copy link
Contributor Author

@stanleyyconsensys stanleyyconsensys Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it is kind of a new network,
+
we try to avoid controller-utils breaking change, as it will introduce breaking change for many controllers
and soon we will introduce a new controller to store the information remotely

Comment on lines 12 to 14
- Add MegaETH Testnet V2 support ([#7272](https://github.com/MetaMask/core/pull/7272))
- Add `megaeth-testnet-v2` in method `getDefaultCustomNetworkConfigurationsByChainId`
- Add `megaeth-testnet-v2` in type `AdditionalDefaultNetwork`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these are internal functions/types. It would be better to mention the behavior that consumers would see.

I think we can capture this by saying:

Suggested change
- Add MegaETH Testnet V2 support ([#7272](https://github.com/MetaMask/core/pull/7272))
- Add `megaeth-testnet-v2` in method `getDefaultCustomNetworkConfigurationsByChainId`
- Add `megaeth-testnet-v2` in type `AdditionalDefaultNetwork`
- Add MegaETH Testnet "v2" as a default custom network ([#7272](https://github.com/MetaMask/core/pull/7272))
- The URL for this is `https://timothy.megaeth.com/rpc` rather than `https://carrot.megaeth.com/rpc`, and the chain ID has changed from `0x18c6` to `0x18c7`.
- "v1" of this network has not been removed.

### Added

- Add `monad-testnet` to `InfuraNetworkType` ([#7067](https://github.com/MetaMask/core/pull/7067))
- Add MegaETH Testnet V2 to various constants, enums, and types ([#7272](https://github.com/MetaMask/core/pull/7272))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should we put V2 in quotes?

Suggested change
- Add MegaETH Testnet V2 to various constants, enums, and types ([#7272](https://github.com/MetaMask/core/pull/7272))
- Add MegaETH Testnet "v2" to various constants, enums, and types ([#7272](https://github.com/MetaMask/core/pull/7272))

- Add `monad-testnet` to `InfuraNetworkType` ([#7067](https://github.com/MetaMask/core/pull/7067))
- Add MegaETH Testnet V2 to various constants, enums, and types ([#7272](https://github.com/MetaMask/core/pull/7272))
- Add `megaeth-testnet-v2` to `BUILT_IN_NETWORKS`
- Add `megaeth-testnet-v2` and `megaeth-testnet` to `BUILT_IN_CUSTOM_NETWORKS_RPC`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't megaeth-testnet already present?

Suggested change
- Add `megaeth-testnet-v2` and `megaeth-testnet` to `BUILT_IN_CUSTOM_NETWORKS_RPC`
- Add `megaeth-testnet-v2` to `BUILT_IN_CUSTOM_NETWORKS_RPC`

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit a1a912e Dec 10, 2025
281 checks passed
@stanleyyconsensys stanleyyconsensys deleted the chore/add-megaEth-testnet-v2 branch December 10, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants