fix: add decimal bounds to currency rates #7324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
commented
Dec 5, 2025
Prithpal-Sooriya
commented
Dec 5, 2025
Comment on lines
+278
to
+280
| conversionRate: tokenPrice?.price | ||
| ? boundedPrecisionNumber(tokenPrice.price) | ||
| : null, |
Contributor
Author
There was a problem hiding this comment.
Add bounds for the fallback currency fetching.
Prithpal-Sooriya
commented
Dec 5, 2025
Comment on lines
206
to
211
| conversionRate: rate?.value | ||
| ? boundedPrecisionNumber(1 / rate.value) | ||
| : null, | ||
| usdConversionRate: rate?.usd | ||
| ? boundedPrecisionNumber(1 / rate.usd) | ||
| : null, |
Contributor
Author
There was a problem hiding this comment.
Add bounds for main currency fetches.
Prithpal-Sooriya
commented
Dec 5, 2025
salimtb
previously approved these changes
Dec 5, 2025
sahar-fehri
previously approved these changes
Dec 5, 2025
juanmigdr
previously approved these changes
Dec 5, 2025
…bounds-to-currency-rates
6c46db6
salimtb
approved these changes
Dec 5, 2025
sahar-fehri
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds back decimal precision bounding to 9dp for the CurrencyRateController conversionRate properties.
This is so our clients do not crash due to large decimals when using BigNumber (exceeding the 15 significant digit limit)
References
Fixes issues around BigNumber calculations (exceeding the 15 significant digit limit) - https://metamask.sentry.io/issues/7082421955/?project=273505&referrer=slack
Checklist
Note
Bounds
CurrencyRateControllerconversion rates to 9 decimal places and updates tests/changelog accordingly.boundedPrecisionNumberand clampconversionRateandusdConversionRateto 9dp in both Price API path and token price fallback.CurrencyRateController.test.tsto reflect 9dp precision; minor namespace type cleanup.CHANGELOG.mdwith the fix.Written by Cursor Bugbot for commit 6c46db6. This will update automatically on new commits. Configure here.