You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature: my feature nameScenario: user [verb for user action]Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Bumps @metamask/remote-feature-flag-controller to 4.0.0 and refreshes lockfile, updating related @metamask/utils and @metamask/controller-utils versions.
Dependencies:
Upgrade @metamask/remote-feature-flag-controller from ^3.1.0 to ^4.0.0 in package.json.
Update yarn.lock resolutions accordingly, including @metamask/utils to 11.9.0 and @metamask/controller-utils to 11.17.0.
Written by Cursor Bugbot for commit 8a5dc27. This will update automatically on new commits. Configure here.
This PR upgrades @metamask/remote-feature-flag-controller from v3.1.0 to v4.0.0 - a MAJOR version bump. This controller is a critical core dependency that:
Is deeply integrated into the Engine - Initialized in Engine.ts and used across many controllers and messengers
Controls feature flags for virtually all features - The codebase search shows it's used in:
Confirmations (redesign flags)
Perps (perpetuals trading)
Predictions
Earn/Staking (TRX staking, etc.)
Card features
Ramps (buy/sell)
Network controller
Multichain accounts (Bitcoin, Tron, Solana)
Assets (trending tokens)
Token search/discovery
API changes detected - The yarn.lock shows the new version uses @metamask/messenger (v0.3.0) instead of the previous messenger pattern, indicating potential breaking changes in controller communication.
Affects state management - RemoteFeatureFlagControllerState is used across many selectors and components to determine feature availability.
Given this is a major version upgrade of a controller that gates features across the entire application, any regression could disable or break multiple features. All test tags should be run to ensure comprehensive coverage.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumping version of remote-feature-flag-controller to support independent A/B tests introduced in:
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Bumps
@metamask/remote-feature-flag-controllerto 4.0.0 and refreshes lockfile, updating related@metamask/utilsand@metamask/controller-utilsversions.@metamask/remote-feature-flag-controllerfrom^3.1.0to^4.0.0inpackage.json.yarn.lockresolutions accordingly, including@metamask/utilsto11.9.0and@metamask/controller-utilsto11.17.0.Written by Cursor Bugbot for commit 8a5dc27. This will update automatically on new commits. Configure here.