-
Notifications
You must be signed in to change notification settings - Fork 0
PERF Adding multi-output support to PWD implementation in KNeighborsClassifier #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pwd_kncp
Are you sure you want to change the base?
Conversation
I think you can and should use other structures than But I would focus our energy later on this PR as scikit-learn#24076 might be structured again with round of reviews. |
Just linking a comment for when you come back to this cython/cython#4966 (comment). I proposed using a list of Python objects wrapping memoryviews. I've only quickly skimmed this PR so I don't know if it actually does what you need though, so feel free to ignore if it isn't relevant. |
Thanks @da-woods for this proposal. I read this proposal in the original issue. Here, we might want to have instructions run as much as possible (or even solely) in |
No I agree. This is the big limitation of that suggestion. |
@Micky774 Is this implementation in a working state now? |
Reference Issues/PRs
Follows up work in #24076
What does this implement/fix? Explain your changes.
This PR develops proper multi-output support without wasted memory transfer
Any other comments?
Currently broken due to weird memory issues and segfaults surrounding the use of using
vector[memory_view]
type structures. Opening this PR to share and get feedback.