replace Root with Root_(hash, common) in persistent database#16656
Merged
Conversation
Member
|
these are the same commits as https://github.com/MinaProtocol/mina/pull/16650/commits, therefore i will approve |
svv232
approved these changes
Feb 21, 2025
Member
Author
|
!ci-build-me |
georgeee
reviewed
Feb 21, 2025
| | Ok root -> | ||
| (* automatically split Root into (Root_hash, Root_common) *) | ||
| Batch.with_batch t.db ~f:(fun batch -> | ||
| let hash = Root_data.Minimal.Stable.Latest.hash root in |
Member
There was a problem hiding this comment.
It would be cool to remove the existing Root key as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same PR as #16650 , just from a branch in upstream so CI is happy.
This is a follow up for #16624
This PR only contains patch to be merged into compatible. It's compatible because we try to replace
Rootwith(Root_hash, Root_common)when:rootorroot_hashThat means attempting to perform transactions on old persistence database, the bottleneck will occur once and not after.
Here's the PR for the testcase.