Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Inputs, Menu: Standardize default origin point #10071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 25, 2024
Merged

Inputs, Menu: Standardize default origin point #10071

merged 6 commits into from
Oct 25, 2024

Conversation

danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Oct 21, 2024 •
edited
Loading

Description

The default origin points for input popovers aren't consistent. This makes them industry standard.

Autocomplete opens one way

image

Select a different way

image

Material Design 2

image

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Date picker:

image

image

Menu

image

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers changed the title Use consistent anchor origin for default Picker, Select: Fix default origin point Oct 22, 2024
@danielchalmers danielchalmers changed the title Picker, Select: Fix default origin point Inputs: Fix default origin point Oct 22, 2024
@danielchalmers danielchalmers marked this pull request as ready for review October 22, 2024 19:42
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (928d946) to head (daf261c).
Report is 499 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10071      +/-   ##
==========================================
- Coverage   91.14%   91.13%   -0.01%     
==========================================
  Files         411      411              
  Lines       12482    12481       -1     
  Branches     2422     2422              
==========================================
- Hits        11377    11375       -2     
  Misses        560      560              
- Partials      545      546       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@henon henon added bug Unexpected behavior or functionality not working as intended breaking change This change will require consumer code updates v8 labels Oct 24, 2024
@henon
Copy link
Collaborator

henon commented Oct 24, 2024 •
edited
Loading

I guess only @Garderoben knows why MudSelect opens the way it does ,overlapping the input. I'll defer this decision to him.

That being said, I have noticed this and it has perplexed me on all components where the dropdown opens over the component itself. I just never questioned @Garderoben's knowledge of how it should be.

@Garderoben
Copy link
Member

I guess only @Garderoben knows why MudSelect opens the way it does ,overlapping the input. I'll defer this decision to him.

That being said, I have noticed this and it has perplexed me on all components where the dropdown opens over the component itself. I just never questioned @Garderoben's knowledge of how it should be.

Lets make it consistent across the library and change it

@henon
Copy link
Collaborator

henon commented Oct 25, 2024

@danielchalmers when you merge this, please don't forget to update the v8 migration guide

@danielchalmers danielchalmers mentioned this pull request Oct 25, 2024
Open
@danielchalmers danielchalmers changed the title Inputs: Fix default origin point Inputs: Standardize default origin point Oct 25, 2024
@danielchalmers danielchalmers changed the title Inputs: Standardize default origin point Inputs, Menu: Standardize default origin point Oct 25, 2024
@danielchalmers danielchalmers merged commit 7576772 into MudBlazor:dev Oct 25, 2024
4 checks passed
@danielchalmers danielchalmers deleted the anchor-origin branch October 25, 2024 14:42
@ScarletKuro
Copy link
Member

Was added to #9953 (comment)

@danielchalmers danielchalmers mentioned this pull request Oct 27, 2024
Merged
7 tasks
@ScarletKuro
Copy link
Member

This commit broke the select:
#10106 (review)

@danielchalmers danielchalmers mentioned this pull request Oct 28, 2024
Merged
7 tasks
@ScarletKuro ScarletKuro mentioned this pull request Nov 13, 2024
Closed
4 tasks
@danielchalmers danielchalmers mentioned this pull request Nov 18, 2024
Merged
7 tasks
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
@danielchalmers @LLauter
Inputs, Menu: Standardize default origin point (MudBlazor#10071)
fce7a89
@danielchalmers danielchalmers added regression Previously worked and now fails and removed accidental break labels Jul 1, 2025
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Open
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garderoben Garderoben Garderoben approved these changes

@henon henon Awaiting requested review from henon

Assignees
No one assigned
Labels
breaking change This change will require consumer code updates bug Unexpected behavior or functionality not working as intended regression Previously worked and now fails
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielchalmers @henon @Garderoben @ScarletKuro