-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MudSelect, MudMenu: Fix max height exceeds window #10216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudSelect, MudMenu: Fix max height exceeds window #10216
Conversation
…en height and is a mud-list. (mud-select or mud-menu). This enables overflow to work as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/MudBlazor.UnitTests.Viewer/TestComponents/Menu/MenuNoFlipScrollBarTest.razor
Outdated
Show resolved
Hide resolved
|
so the menu won't fit if it goes down from opening position. Moving the sub-menu "up" seemed odd to me so I was happy when you posted the spec showing a scrollbar. Here's 24px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks Versile Johnson II |
Description
Popover mud-list items create scrollbars in the main window when they exceed screen height. This can only happen if the flip function can't flip them without exceeding the top or left. (right in RTL) These changes add a max-height property if and ONLY if a mud-list in a popover would create a scrollbar outside of itself.
Resolves #10204
How Has This Been Tested?
Visual Tests Below
Type of Changes
Checklist
dev
).