MudTextField: Fix line height for outlined frame #10649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good find. Could you try |
|
Just tested and updated the PR, 1.15rem also look perfect. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10649 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 426 426
Lines 13378 13386 +8
Branches 2575 2576 +1
=======================================
+ Hits 12280 12288 +8
Misses 527 527
Partials 571 571 ☔ View full report in Codecov by Sentry. |
danielchalmers
approved these changes
Jan 18, 2025
|
Thank you! |
7 tasks
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The text on a outlined MudTextField is cropped at the bottom for letters who go below the textline, e.g. g,y,j,q,p,..
It could be seen in the official documentation, the 'g' of "Single select" is cut.
It could also be seen in the screenshot, especially at the 'g' in the end of the string "QjpqyLlg".
How Has This Been Tested?
visually
Type of Changes
Checklist
dev).