Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MudOverlay: Introduce mud-skip-overlay-section #10666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 21, 2025
Merged

MudOverlay: Introduce mud-skip-overlay-section #10666

merged 5 commits into from
Jan 21, 2025

Conversation

versile2
Copy link
Contributor

Description

Allow Drawer/Dialog separation and introduce class mud-skip-overlay-section
Fix overlay positioning logic to only position overlays inside mud-popover-provider (nested overlays where someone is using an autocomplete/select/datepicker/etc inside a dialog/drawer/other popover)
Resolves #10587
Resolves #10658

How Has This Been Tested?

Visually, Unit tests adjusted to use correct container for overlays

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jan 20, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (d9f27e2) to head (f5c05f3).
Report is 18 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #10666   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         426      426           
  Lines       13374    13388   +14     
  Branches     2575     2576    +1     
=======================================
+ Hits        12276    12290   +14     
  Misses        527      527           
  Partials      571      571

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

I guess this partially reverts #10467? as the explicit:

var providerComp = Context.RenderComponent<MudPopoverProvider>();

is not needed anymore again

@versile2
Copy link
Contributor Author

I guess this partially reverts #10467? as the explicit:

var providerComp = Context.RenderComponent<MudPopoverProvider>();

is not needed anymore again

well the mudPopover.js didn't exclude it so it finishes that fix. and correct Drawer and Dialog will use the skip class and have their own overlay outside of the popover-provider. Also it will now properly accept Absolute and not try and reposition the overlay.

@danielchalmers danielchalmers changed the title Bug - Overlay Separation MudOverlay: Introduce mud-skip-overlay-section Jan 21, 2025
@danielchalmers danielchalmers merged commit 502b074 into MudBlazor:dev Jan 21, 2025
6 checks passed
@danielchalmers
Copy link
Member

danielchalmers commented Jan 21, 2025 •
edited
Loading

Changed the title but didn't update commit message, oops

This was referenced Jan 23, 2025
Closed
Open
@seedysoft seedysoft mentioned this pull request Jan 27, 2025
Merged
@versile2 versile2 deleted the fix/overlay branch January 30, 2025 14:21
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Open
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielchalmers danielchalmers danielchalmers approved these changes

@ScarletKuro ScarletKuro ScarletKuro approved these changes

Assignees
No one assigned
Labels
bug Unexpected behavior or functionality not working as intended
Projects
None yet
Milestone
No milestone
3 participants
@versile2 @ScarletKuro @danielchalmers