Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (c4cb9af) to head (33ac98e).
Report is 6 commits behind head on dev.

@@           Coverage Diff           @@
##              dev   #10743   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files         427      427           
  Lines       13425    13428    +3     
  Branches     2589     2591    +2     
=======================================
+ Hits        12329    12332    +3     
  Misses        523      523           
  Partials      573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nice implementation.

I think @henon wanted to see this on nested context menus as well if you're willing to take a look. Though I'm not sure how the origin point is supposed to work in RTL

Yeah I'll take a look soon probably won't take long. As for the origin point I don't think it matters since they can change it on their own and any change we make could be a breaking change in some cases.

It looks like the width of the gap is different in RTL

Ideally it should be the same, I think

It looks like the width of the gap is different in RTL

Ideally it should be the same, I think

nice catch. Fixed now.

They should both have the reduced margin of the original pic, not the increased margin, no?

The previous style was
margin: -12px -2px -12px -12px

I just matched left margin with right margin so the new style is

margin: -12px -2px -12px -2px;

I did look at the -12px style on both sides and it didn't look right to me, just too close but this matches what LTR is for RTL and they can adjust margins with their text as they see fit?

You were right, looks better.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Thanks