CSS: Fix CSS issues reported by sonar #10757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Was this automated? |
Nope, all manual. |
danielchalmers
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Overall looks good. Let's merge this at the start of the next release cycle so we have more time to dogfood it. Me and @Garderoben agree that we can go ahead and see what happens.
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes most, if not all, CSS issues reported by sonar.
We copy the MudBlazor SASS files into our project to generate a complete
app.min.cssfile in build output so sonar reports a few of the issues that I also found in the MudBlazor sonar issues, so I decided to clean up the entire list.I completely removed
_markdowncode.scssas I found no reference to that file anywhere else.How Has This Been Tested?
Visually by comparing
dev.mudblazor.comdocs with local docs (and verifying CSS output in some cases).Type of Changes
Checklist
dev).