MudCollapse: Apply scroll to expanded content overflow #10948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScarletKuro
reviewed
Feb 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10948 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 427 427
Lines 13585 13590 +5
Branches 2603 2604 +1
=======================================
+ Hits 12484 12489 +5
Misses 526 526
Partials 575 575 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ScarletKuro
approved these changes
Mar 2, 2025
|
danielchalmers
approved these changes
Mar 11, 2025
|
Thanks! |
This was referenced Aug 1, 2025
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow collapse content to scroll when it exceeds the max height of the container.
In reviewing this I also found a bug where if a
MudCollapsehasExpandedset toTrueon initial load, themud-collapse-enteredclass was not being applied. It instead remained atmud-collapse-entering, since the_statedoesn't get updated due to AnimationEndAsync not being called.Resolves: #10939
How Has This Been Tested?
visually & unit test updates
Type of Changes
Checklist
dev).