MudDrawer: Fix stall when loading #11009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents stall when loading the drawer by no longer awaiting viewport subscription
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11009 +/- ##
==========================================
- Coverage 91.05% 91.05% -0.01%
==========================================
Files 429 429
Lines 13956 13956
Branches 2698 2698
==========================================
- Hits 12708 12707 -1
Misses 646 646
- Partials 602 603 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ScarletKuro Requesting review |
|
@ScarletKuro bumping review request |
ScarletKuro
approved these changes
Jun 12, 2025
This was referenced Aug 1, 2025
Closed
This was referenced Aug 14, 2025
This was referenced Aug 25, 2025
This was referenced Sep 3, 2025
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents stall when loading the drawer by no longer awaiting viewport subscription.
Description
Currently the Drawer waits for the viewport subscription to complete which can take several seconds (due to javascript calls).
This seems unnecessary as the callback invokes on the main thread anyway.
How Has This Been Tested?
All tests pass
Type of Changes
Checklist
dev).