Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

versile2
Copy link
Contributor

@versile2 versile2 commented Mar 28, 2025

Description

Resolves #11044
There were some instances of slow popover moving when latency was involved. The obvious culprit is the debounce/throttle used inside the connect method from #10856. Left debounce and throttle on resize/scroll since the popover is already positioned and this will avoid unnecessary js calls during one of those events.

How Has This Been Tested?

Tested visually in Viewer project and Docs project.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

- Only allow throttle and debounce on resize/scroll.
- revert 10856 changes inside the connect method

- V2
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Mar 28, 2025
@versile2
Copy link
Contributor Author

It would be trivial to take it out of resize/scroll if you think it should just completely revert

@versile2 versile2 requested a review from ScarletKuro March 28, 2025 17:52
Copy link

@ScarletKuro ScarletKuro changed the title Revert Parts Of mudPopover.js MudPopover: Fix latency delay (partial revert of #10856) Mar 28, 2025
@ScarletKuro ScarletKuro changed the title MudPopover: Fix latency delay (partial revert of #10856) MudPopover: Fix positioning delay (partial revert of #10856) Mar 28, 2025
@ScarletKuro ScarletKuro merged commit 984a6d5 into MudBlazor:dev Mar 28, 2025
4 checks passed
@versile2 versile2 deleted the revert/10856 branch April 9, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior or functionality not working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

popover delay in positioning
2 participants