nit

MudBlazor · ScarletKuro · Apr 19, 2025 · Apr 4, 2025 · Apr 4, 2025 · Apr 4, 2025
commit 692329cb313599ca4d52ef1e95a420b1e1030ce4
diff --git a/src/MudBlazor.UnitTests.Viewer/TestComponents/Menu/MenuEdgeCasesTest.razor b/src/MudBlazor.UnitTests.Viewer/TestComponents/Menu/MenuEdgeCasesTest.razor
@@ -81,7 +81,7 @@
         <MudPaper style="width: 70px;">
             @* On initial load these don't respect the mouseover leave event only activating and not deactivating *@
             <MudNavMenu>
-                @foreach (var menu in menuList)
+                @foreach (var menu in _menuList)
                 {
                     <MudMenu Icon="@Icons.Material.Filled.Mouse" FullWidth="true" ActivationEvent="@MouseEvent.MouseOver"
                              AnchorOrigin="Origin.BottomRight" TransformOrigin="Origin.CenterLeft">
@@ -174,6 +174,6 @@
 
 @code {
     public static string __description__ = "4 menu edge cases for visual testing, initial load, in appbar, nested, and in dialog.";
-    private readonly string[] menuList = ["1", "2", "3", "4", "5", "6", "7", "8", "9", "10"];
-    private bool _visible = false;
+    private readonly string[] _menuList = ["1", "2", "3", "4", "5", "6", "7", "8", "9", "10"];
+    private bool _visible;
 }
diff --git a/src/MudBlazor.UnitTests.Viewer/TestComponents/Popover/PopoverFlipDirectionTest.razor b/src/MudBlazor.UnitTests.Viewer/TestComponents/Popover/PopoverFlipDirectionTest.razor
@@ -1,13 +1,13 @@
 
 <MudStack Spacing="2">
     <MudButton OnClick="OnExpandCollapseClick">@(_expanded ? "Collapse" : "Expand")</MudButton>
-    <MudButton OnClick="OnExpandCollapseFor5sClick">@(_expanded ? "Collapse" : "Expand") for 5 s</MudButton>
-    <MudButton OnClick="OnExpandListIn5s">Expand list in 5 s</MudButton>
+    <MudButton OnClick="OnExpandCollapseFor5sClickAsync">@(_expanded ? "Collapse" : "Expand") for 5 s</MudButton>
+    <MudButton OnClick="OnExpandListIn5sAsync">Expand list in 5 s</MudButton>
     <MudDivider />
     <MudCollapse Expanded="_expanded">
         <div style="@($"height: {_height}px")">
-            <MudNumericField T="Int32" @bind-Value="_height" Min="0" Label="Section height (in px)" />
-            <MudCheckBox T="Boolean" @bind-Value="_hideBottom" Label="Hide bottom section" />
+            <MudNumericField T="int" @bind-Value="_height" Min="0" Label="Section height (in px)" />
+            <MudCheckBox T="bool" @bind-Value="_hideBottom" Label="Hide bottom section" />
             <MudSelect T="Origin"
                        Label="Anchor Origin"
                        @bind-Value="@_anchor">
@@ -71,48 +71,42 @@
     @if (!_hideBottom)
     {
         <MudButton OnClick="OnExpandCollapseClick">@(_expanded ? "Collapse" : "Expand")</MudButton>
-        <MudButton OnClick="OnExpandCollapseFor5sClick">@(_expanded ? "Collapse" : "Expand") for 5 s</MudButton>
+        <MudButton OnClick="OnExpandCollapseFor5sClickAsync">@(_expanded ? "Collapse" : "Expand") for 5 s</MudButton>
         <MudDivider />
         <MudCollapse Expanded="_expanded">
             <div style="@($"height: {_heightBottom}px")">
-                <MudNumericField T="Int32" @bind-Value="_heightBottom" Min="0" Label="Section height (in px)" />
+                <MudNumericField T="int" @bind-Value="_heightBottom" Min="0" Label="Section height (in px)" />
             </div>
         </MudCollapse>
     }
 </MudStack>
 @code {
-
-
-
     public static string __description__ = "Popover should take the best available space";
 
-    private Int32 _height = 600;
-    private Int32 _heightBottom = 400;
     private bool _hideBottom;
     private bool _expandList;
+    private bool _expanded = true;
+    private int _height = 600;
+    private int _heightBottom = 400;
     private Origin _anchor = Origin.BottomLeft;
     private Origin _transform = Origin.TopLeft;
-    private bool _expanded = true;
 
-	private readonly DropdownSettings _dropdownSettings = new DropdownSettings
-	{
+	private readonly DropdownSettings _dropdownSettings = new()
+    {
 		OverflowBehavior = OverflowBehavior.FlipAlways
 	};
 
-	private void OnExpandCollapseClick()
-	{
-		_expanded = !_expanded;
-	}
+	private void OnExpandCollapseClick() => _expanded = !_expanded;
 
-	private async Task OnExpandCollapseFor5sClick()
+    private async Task OnExpandCollapseFor5sClickAsync()
 	{
-		var cur = _expanded;
-		_expanded = !cur;
-		await Task.Delay(5000);
-		_expanded = cur;
-	}
+		var expanded = _expanded;
+        _expanded = !expanded;
+        await Task.Delay(5000);
+        _expanded = expanded;
+    }
 
-	private async Task OnExpandListIn5s()
+	private async Task OnExpandListIn5sAsync()
 	{
 		_expandList = false;
 		await Task.Delay(5000);

diff --git a/src/MudBlazor.UnitTests.Viewer/TestComponents/Tooltip/TooltipNotRemovedTest.razor b/src/MudBlazor.UnitTests.Viewer/TestComponents/Tooltip/TooltipNotRemovedTest.razor
@@ -1,10 +1,12 @@
-
-<MudContainer Fixed="true" @key="_key">
+<MudContainer Fixed="true" @key="_key">
     @for (var i = 0; i < 200; i++)
     {
         <div>
+            @{
+                var current = i;
+            }
             <MudTooltip Text="Tooltext buttontip" Delay="0" Duration="0">
-                <MudButton>BTN @i</MudButton>
+                <MudButton>BTN @current</MudButton>
             </MudTooltip>
         </div>
     }
@@ -16,17 +18,18 @@
 
     protected override Task OnInitializedAsync()
     {
-        RunThing().CatchAndLog();
+        var cts = new CancellationTokenSource();
+        RunThingAsync(cts.Token).CatchAndLog();
         return base.OnInitializedAsync();
     }
 
-    private async Task RunThing()
+    private async Task RunThingAsync(CancellationToken cancellationToken)
     {
-        while (true)
+        while (!cancellationToken.IsCancellationRequested)
         {
-            this._key = Guid.NewGuid();
+            _key = Guid.NewGuid();
             InvokeAsync(StateHasChanged).CatchAndLog();
-            await Task.Delay(100);
+            await Task.Delay(100, cancellationToken);
         }
     }
 }
diff --git a/src/MudBlazor/Components/Tooltip/MudTooltip.razor.cs b/src/MudBlazor/Components/Tooltip/MudTooltip.razor.cs
@@ -7,7 +7,7 @@ namespace MudBlazor
 #nullable enable
     public partial class MudTooltip : MudComponentBase
     {
-        internal readonly ParameterState<bool> _visibleState;
+        private readonly ParameterState<bool> _visibleState;
         private Origin _anchorOrigin;
         private Origin _transformOrigin;
         public MudTooltip()