Add seconds to TimePicker #11231
Open
Add seconds to TimePicker #11231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #11231 +/- ##
==========================================
+ Coverage 91.08% 91.10% +0.01%
==========================================
Files 436 436
Lines 14143 14173 +30
Branches 2731 2737 +6
==========================================
+ Hits 12882 12912 +30
+ Misses 639 638 -1
- Partials 622 623 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #4644
Hi MudBlazor maintainer(s)!
I hope you will consider this PR, I wanted to be able the seconds in the TimePicker component, so thought I would have a go at it myself
I made several changes:
TimeEditModeallowsTimeEditModeHoursMinutes: only hours and minutes are editableMinutesSeconds: only minutes and seconds are editableSecondsOnly: only seconds are editableHoursVisibleandSecondsVisibleto change whether the hours and seconds are visible in the picker toobarSecondSelectionStepwhich controls the step for seconds in the same wayMinuteSelectionStepdoes for minutesI also fixed a related issue where the
OpenTowas not being set correctly based on theTimeEditModewhenPickerVariantwas set toStatic. This was becauseOnPickerOpenedAsyncwas never being called to set it correctly so it always opened to the default value forOpenTowhich is hours. To fix this I made currentView nullable and set it inOnParametersSetbased on theTimeEditMode.I know it says to have only one issue per PR, but I thought this was so closely related that it might be allowed to be added, but can create a separate PR if this is a hard rule
One thing I didn't add is a way of keyboard navigation for the seconds part, which I notice is there for hours and minutes. I did this mainly because I wasn't 100% sure which path to take. My main thought was to use ctrl+shft+arrow, but don't know if that might clash with other browser keybindings I'm not aware of
How Has This Been Tested?
I tested this using the Docs project and also an extra project I added locally for testing, but I've also added some unit tests
Type of Changes
Standard usage
HoursVisible and SecondsVisible
Layout before and after
Before
After
Checklist
dev).