Popover: Initial Show When Open="true" #11277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ScarletKuro
approved these changes
May 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11277 +/- ##
==========================================
+ Coverage 91.09% 91.13% +0.03%
==========================================
Files 439 439
Lines 14235 14238 +3
Branches 2759 2759
==========================================
+ Hits 12968 12976 +8
+ Misses 638 635 -3
+ Partials 629 627 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #11259
Popovers that start open weren't receiving a reflow due to the isOpened flag only being set on mutation "mud-popover-open". Now it properly checks on connect if a popover should be open. Most popovers force a reflow due to changes as it's rendered but some don't is why it was not a widespread problem.
How Has This Been Tested?
Visually in WASM and BSS.
Type of Changes
Checklist
dev).