Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ToggleGroup: Fix Fixed Content Visual Options #11306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mckaragoz
Copy link
Member

Description

Changed the design of the component. This only affects when tickmark is on, otherwise the content always on center.

  • When FixedContent true: The content is a CSS grid that divided by 3 equal colums. So the tickmark is always on start and the main content is always centered. Better to use wider or vertical situations.
  • When FixedContent false: The content is a CSS flexbox with justify-center. Better to use narrower situations.
20250507_231243.mp4

Also enhanced the docs. It's now mobile friendly.

@versile2 will also fix the component doesn't work until @bind-Value is described.

How Has This Been Tested?

It's a design PR and tested visually.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 7, 2025
Copy link

sonarqubecloud bot commented May 7, 2025

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.14%. Comparing base (dbb9036) to head (1cb306f).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11306   +/-   ##
=======================================
  Coverage   91.13%   91.14%           
=======================================
  Files         439      439           
  Lines       14238    14248   +10     
  Branches     2759     2763    +4     
=======================================
+ Hits        12976    12986   +10     
  Misses        635      635           
  Partials      627      627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant