Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MudColorPicker: Reduce default throttle #11368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

MudColorPicker: Reduce default throttle #11368

merged 1 commit into from
May 20, 2025

Conversation

danielchalmers
Copy link
Member

Description

I think we were too cautious before at the expense of user experience, especially when taking into account the throttle was for Server but still enabled on WASM.
 

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

After/Before:

Video5.mp4

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Request for adding a new feature or enhancing existing functionality (not fixing a defect) PR: needs review labels May 20, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (13fa8ee) to head (b74a0ee).
Report is 5 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #11368   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         465      465           
  Lines       14407    14402    -5     
  Branches     2789     2785    -4     
=======================================
- Hits        13127    13123    -4     
  Misses        643      643           
+ Partials      637      636    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ScarletKuro ScarletKuro merged commit dc4b22d into MudBlazor:dev May 20, 2025
7 checks passed
This was referenced Jul 22, 2025
Closed
Closed
Closed
This was referenced Aug 1, 2025
Closed
Open
Open
Closed
Merged
Open
Open
This was referenced Aug 14, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 25, 2025
Merged
Closed
Closed
Merged
This was referenced Sep 3, 2025
Open
Merged
This was referenced Sep 8, 2025
Open
Open
Open
Open
This was referenced Sep 22, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

Assignees
No one assigned
Labels
enhancement Request for adding a new feature or enhancing existing functionality (not fixing a defect)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielchalmers @ScarletKuro