MudStepper: Remove StepStyle property #11589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the now-unnecessary StepStyle parameter from MudStepper in favor of using StepClass exclusively, and updates related render logic.
- Deleted the
StepStyleproperty and its XML doc inMudStepper.razor.cs - Removed inline
style="@StepStyle"from the completed-step<div>inMudStepper.razor - Cleaned up
MudStep.csby removing theStylesbuilder and adjusting theClassnamebuilder
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MudStepper.razor.cs | Removed StepStyle parameter and its docs |
| MudStepper.razor | Dropped the inline style attribute from steps |
| MudStep.cs | Removed Styles property and revised Classname builder |
Comments suppressed due to low confidence (1)
src/MudBlazor/Components/Stepper/MudStepper.razor:50
- [nitpick] Verify that all other step rendering blocks (e.g., active, inactive, error states) also have their
styleattributes removed to maintain consistency after droppingStepStyle.
<div class="@StepClassname mud-stepper-complete">
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11589 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 466 466
Lines 14699 14699
Branches 2855 2854 -1
=======================================
Hits 13407 13407
Misses 646 646
Partials 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jul 21, 2025
Closed
Closed
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
This was referenced Aug 5, 2025
Open
This was referenced Aug 14, 2025
This was referenced Aug 24, 2025
This was referenced Sep 3, 2025
This was referenced Sep 8, 2025
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was spun off from #11407 because the flexibility of an experimental component allows us to remove this property earlier and without prior obsoletion. See that PR for more info on best practices.
In short: Use StepClass instead.
How Has This Been Tested?
Type of Changes
Checklist
dev).