-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MudDataGrid : Refresh on collection changed #11822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ScarletKuro
merged 2 commits into
MudBlazor:dev
from
vernou:11758-datagrid-collectionchanged
Aug 25, 2025
Merged
MudDataGrid : Refresh on collection changed #11822
ScarletKuro
merged 2 commits into
MudBlazor:dev
from
vernou:11758-datagrid-collectionchanged
Aug 25, 2025
+58
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
versile2
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I've examined the tests, verified the test fails before the fix and the fix resolves the test case.
V
ScarletKuro
approved these changes
Aug 25, 2025
This was referenced Sep 3, 2025
This was referenced Sep 8, 2025
This was referenced Sep 22, 2025
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11758
Currently, when
MudDataGrid.Items
is set with a observable collection and the collection is modified, the change isn't rendered.This PR fix it. When the collection is modified,
StateHasChanged
is called to refresh the UI.Moreover, I move the callback of
INotifyCollectionChanged.CollectionChanged
inInvokeAsync
, because the collection can be changed in a other thread (like in bug issue #11758 where the collection is modified in a trigger).Checklist:
dev
).