MudSnackbar: Snapshot enumeration to avoid concurrent collection access#13187
Merged
Conversation
Agent-Logs-Url: https://github.com/MudBlazor/MudBlazor/sessions/5d58be55-e5af-4702-8e7e-7b5fe2e8c86d Co-authored-by: danielchalmers <[email protected]>
Agent-Logs-Url: https://github.com/MudBlazor/MudBlazor/sessions/3af8bb97-c590-4c5a-9eef-31a0add27b75 Co-authored-by: danielchalmers <[email protected]>
Copilot created this pull request from a session on behalf of
danielchalmers
May 11, 2026 18:02
View session
danielchalmers
approved these changes
May 11, 2026
This was referenced May 26, 2026
This was referenced Jun 29, 2026
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISnackbar.ShownSnackbarscould expose a deferred enumeration over the mutable backing list after the lock had been released. This change narrows the fix to that concurrency edge by returning a stable snapshot and adding coverage for enumeration after subsequent mutations.Snackbar service
ShownSnackbarsinstead of a deferredTake(...)over the live list.MaxDisplayedSnackbarsbehavior and ordering while making callers safe from post-read mutations.Regression coverage
ShownSnackbars, mutates the service state, and verifies the original enumeration remains unchanged.